Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717862

Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

Show all headers | View raw

On 08/22/2017 02:44 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 22 Aug 2017 14:26:47 -0700
> 
>> Priit reported that stmmac was crashing with the trace below. This is because
>> phy_attached_print() is called too early right after the PHY device has been
>> found, but before it has a driver attached, since that is only done in
>> phy_probe() which occurs later.
>>
>> Fix this by dealing with a possibly NULL phydev->drv point since that can
>> happen here, but could also happen if we voluntarily did an unbind of the
>> PHY device with the PHY driver.
>  ...
>> Tested-By: Priit Laes <plaes@plaes.org>
>> Fixes: fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> "net-next"?  The commit which introduced this problem is in 'net', don't we want
> to fix it there?

Oh yes we do, somehow I thought the commit was just in "net-next" hence
the subject, the patch applies cleanly to "net" as well.

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print() Florian Fainelli <f.fainelli@gmail.com> - 2017-08-22 23:30 +0200
  Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in  phy_attached_print() David Miller <davem@davemloft.net> - 2017-08-22 23:50 +0200
  Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in  phy_attached_print() Florian Fainelli <f.fainelli@gmail.com> - 2017-08-22 23:50 +0200
  Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in  phy_attached_print() David Miller <davem@davemloft.net> - 2017-08-22 23:50 +0200

csiph-web