Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()
Date	2017-08-22 23:50 +0200
Message-ID	<uhpdD-8bX-5@gated-at.bofh.it> (permalink)
References	<uhoUi-82K-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 22 Aug 2017 14:26:47 -0700

> Priit reported that stmmac was crashing with the trace below. This is because
> phy_attached_print() is called too early right after the PHY device has been
> found, but before it has a driver attached, since that is only done in
> phy_probe() which occurs later.
> 
> Fix this by dealing with a possibly NULL phydev->drv point since that can
> happen here, but could also happen if we voluntarily did an unbind of the
> PHY device with the PHY driver.
 ...
> Tested-By: Priit Laes <plaes@plaes.org>
> Fixes: fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

"net-next"?  The commit which introduced this problem is in 'net', don't we want
to fix it there?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print() Florian Fainelli <f.fainelli@gmail.com> - 2017-08-22 23:30 +0200
  Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in  phy_attached_print() David Miller <davem@davemloft.net> - 2017-08-22 23:50 +0200
  Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in  phy_attached_print() Florian Fainelli <f.fainelli@gmail.com> - 2017-08-22 23:50 +0200
  Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in  phy_attached_print() David Miller <davem@davemloft.net> - 2017-08-22 23:50 +0200

csiph-web