Re: [PATCH] ravb: make mdiobb_ops const

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ravb: make mdiobb_ops const
Date	2017-08-22 14:10 +0200
Message-ID	<uhgam-2av-7@gated-at.bofh.it> (permalink)
References	<uhcq7-83s-33@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello!

On 08/22/2017 11:08 AM, Bhumika Goyal wrote:

> Make these const as they are only stored in a const field of a
> mdiobb_ctrl structure.

> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>   drivers/net/ethernet/renesas/ravb_main.c | 2 +-
>   drivers/net/ethernet/renesas/sh_eth.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

    If you're fixing both Renesas drivers at once, your subject should be 
"renesas: make mdiobb_ops const". With that fixed, you have my:

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ravb: make mdiobb_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-22 10:10 +0200
  Re: [PATCH] ravb: make mdiobb_ops const Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-22 14:10 +0200
  Re: [PATCH] ravb: make mdiobb_ops const Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-08-22 14:10 +0200

csiph-web