Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717348

Re: [PATCH] ravb: make mdiobb_ops const

Show all headers | View raw

On Tue, Aug 22, 2017 at 2:03 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 08/22/2017 11:08 AM, Bhumika Goyal wrote:
>> Make these const as they are only stored in a const field of a
>> mdiobb_ctrl structure.
>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>> ---
>>   drivers/net/ethernet/renesas/ravb_main.c | 2 +-
>>   drivers/net/ethernet/renesas/sh_eth.c    | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>
>    If you're fixing both Renesas drivers at once, your subject should be
> "renesas: make mdiobb_ops const". With that fixed, you have my:

"net: renesas: make mdiobb_ops const"?
There are plenty of other Renesas-specific drivers spread all over the tree.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ravb: make mdiobb_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-22 10:10 +0200
  Re: [PATCH] ravb: make mdiobb_ops const Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-22 14:10 +0200
  Re: [PATCH] ravb: make mdiobb_ops const Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-08-22 14:10 +0200

csiph-web