Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717281

[tip:perf/core] perf annotate browser: Circulate percent, total-period and nr-samples view

Show all headers | View raw

Commit-ID:  3a555c7799de69d73826eccc9a21948a5775d4d3
Gitweb:     http://git.kernel.org/tip/3a555c7799de69d73826eccc9a21948a5775d4d3
Author:     Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Fri, 18 Aug 2017 17:47:08 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 18 Aug 2017 11:23:20 -0300

perf annotate browser: Circulate percent, total-period and nr-samples view

Using the existing 't' hotkey, support the three views: percent, total
period and number of samples on the annotate TUI browser, circulating
them like below:

  Percent -> Total Period -> Nr Samples -> Percent ...

Committer notes:

Removed new 'e' hotkey, should be resubmitted as a separate patch, with
proper justification for its inclusion.

Suggested-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Milian Wolff <milian.wolff@kdab.com>
Link: http://lkml.kernel.org/r/1503046028-5691-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/browsers/annotate.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index faca1b9..ba0aee5 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -835,7 +835,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
 		"n             Search next string\n"
 		"o             Toggle disassembler output/simplified view\n"
 		"s             Toggle source code view\n"
-		"t             Toggle total period view\n"
+		"t             Circulate percent, total period, samples view\n"
 		"/             Search string\n"
 		"k             Toggle line numbers\n"
 		"r             Run available scripts\n"
@@ -912,8 +912,13 @@ show_sup_ins:
 			}
 			continue;
 		case 't':
-			annotate_browser__opts.show_total_period =
-			  !annotate_browser__opts.show_total_period;
+			if (annotate_browser__opts.show_total_period) {
+				annotate_browser__opts.show_total_period = false;
+				annotate_browser__opts.show_nr_samples = true;
+			} else if (annotate_browser__opts.show_nr_samples)
+				annotate_browser__opts.show_nr_samples = false;
+			else
+				annotate_browser__opts.show_total_period = true;
 			annotate_browser__update_addr_width(browser);
 			continue;
 		case K_LEFT:

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view Taeung Song <treeze.taeung@gmail.com> - 2017-08-18 10:50 +0200
  Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total  period and samples view Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-18 16:30 +0200
    Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total  period and samples view Taeung Song <treeze.taeung@gmail.com> - 2017-08-21 07:50 +0200
      Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total  period and samples view Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-21 21:20 +0200
  [tip:perf/core] perf annotate browser: Circulate percent,  total-period and nr-samples view tip-bot for Taeung Song <tipbot@zytor.com> - 2017-08-22 12:30 +0200

csiph-web