Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1716790

Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

Show all headers | View raw

Em Mon, Aug 21, 2017 at 02:47:09PM +0900, Taeung Song escreveu:
> 
> 
> On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu:
> > > With a existing 't' hotkey, support the three view based on percent,
> > > total period and number of samples on the annotate TUI browser,
> > > circulating them like below:
> > > 
> > >    Percent -> Period -> Samples -> Percent ...
> > > 
> > > Suggested-by: Namhyung Kim <namhyung@kernel.org>
> > > Cc: Milian Wolff <milian.wolff@kdab.com>
> > > Cc: Jiri Olsa <jolsa@redhat.com>
> > > Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> > > ---
> > 
> > Ok, here I removed this part, that is not documented in the patch nor in
> > the 'h' help screen, if you think it should be considered, please
> > resubmit it with a proper explanation:
> 
> I'm really sorry. The case 'e' code is a residue..
> I missed removing the code.
> Thank you for indicating my mistakes.
> 
> Do I resend this patchkit based on your changes ?
> Or, will you modify it by yourself ?

I fixed it myself, sending to Ingo now.

Thanks!

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view Taeung Song <treeze.taeung@gmail.com> - 2017-08-18 10:50 +0200
  Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total  period and samples view Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-18 16:30 +0200
    Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total  period and samples view Taeung Song <treeze.taeung@gmail.com> - 2017-08-21 07:50 +0200
      Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total  period and samples view Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-21 21:20 +0200
  [tip:perf/core] perf annotate browser: Circulate percent,  total-period and nr-samples view tip-bot for Taeung Song <tipbot@zytor.com> - 2017-08-22 12:30 +0200

csiph-web