Re: [PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare

Path	csiph.com!news.freedyn.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod
From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare
Date	Wed, 23 Aug 2017 21:40:01 +0200
Message-ID	<uhJFn-4ES-5@gated-at.bofh.it> (permalink)
References	<ugXr5-6yO-49@gated-at.bofh.it>
X-Original-To	Alexandre Belloni <alexandre.belloni@free-electrons.com>
X-Me-Helo	belgarion
X-Me-Auth	amFyem1pay5yb2JlcnRAb3JhbmdlLmZy
X-Me-Date	Wed, 23 Aug 2017 21:33:04 +0200
X-Me-IP	90.55.206.157
X-URL	http://belgarath.falguerolles.org/
User-Agent	Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Cc	linux-rtc@vger.kernel.org, Rob Herring <robh@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 23 Aug 2017 21:33:01 +0200
X-Original-Message-ID	<87bmn6qdua.fsf@belgarion.home>
X-Original-References	<20170821160038.22650-1-alexandre.belloni@free-electrons.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1718597

Show key headers only | View raw

Alexandre Belloni <alexandre.belloni@free-electrons.com> writes:

> In the error path of sa1100_rtc_open(), info->clk is disabled which will
> happen again in sa1100_rtc_remove() when the module is removed whereas it
> is only enabled once in sa1100_rtc_init().
>
> Fixes: 0cc0c38e9139 ("drivers/rtc/rtc-sa1100.c: move clock enable/disable to probe/remove")
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-21 18:10 +0200
  Re: [PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-23 21:40 +0200

csiph-web