Re: [PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare
Date	2017-08-23 21:40 +0200
Message-ID	<uhJFn-4ES-5@gated-at.bofh.it> (permalink)
References	<ugXr5-6yO-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Alexandre Belloni <alexandre.belloni@free-electrons.com> writes:

> In the error path of sa1100_rtc_open(), info->clk is disabled which will
> happen again in sa1100_rtc_remove() when the module is removed whereas it
> is only enabled once in sa1100_rtc_init().
>
> Fixes: 0cc0c38e9139 ("drivers/rtc/rtc-sa1100.c: move clock enable/disable to probe/remove")
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-21 18:10 +0200
  Re: [PATCH] rtc: sa1100: fix unbalanced clk_prepare_enable/clk_disable_unprepare Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-23 21:40 +0200

csiph-web