Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources

From	"Luck, Tony" <tony.luck@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources
Date	2017-08-23 19:00 +0200
Message-ID	<uhHay-30H-15@gated-at.bofh.it> (permalink)
References	<uhi2t-3sd-7@gated-at.bofh.it> <uhi2t-3sd-5@gated-at.bofh.it> <uhjUC-4K6-23@gated-at.bofh.it> <uhGRd-2TW-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 04:37:43PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Luck, Tony [mailto:tony.luck@intel.com]
> > Maybe you should add the other instruction types that make sense here
> > (ACPI_EINJ_READ_REGISTER, ACPI_EINJ_READ_REGISTER_VALUE and
> > ACPI_EINJ_WRITE_REGISTER) as a sanity check against the BIOS giving you an
> > action in the trigger table that doesn't involve a memory access?
> > 
> 
> Yes, in that case we can do:
> entry->instruction <= ACPI_EINJ_WRITE_REGISTER_VALUE
> 
> That would cover all the memory access instructions and protect against invalid
> instructions.
> 
> How does that sound?

Perfect.

Acked-by: Tony Luck <tony.luck@intel.com>

-Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region  from Trigger resources "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-08-22 16:10 +0200
  Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region  from Trigger resources "Luck, Tony" <tony.luck@intel.com> - 2017-08-22 18:10 +0200
    RE: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region  from Trigger resources "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-08-23 18:40 +0200
      Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region  from Trigger resources "Luck, Tony" <tony.luck@intel.com> - 2017-08-23 19:00 +0200

csiph-web