Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718514
| From | "Ghannam, Yazen" <Yazen.Ghannam@amd.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources |
| Date | 2017-08-23 18:40 +0200 |
| Message-ID | <uhGRd-2TW-39@gated-at.bofh.it> (permalink) |
| References | <uhi2t-3sd-7@gated-at.bofh.it> <uhi2t-3sd-5@gated-at.bofh.it> <uhjUC-4K6-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> -----Original Message-----
> From: Luck, Tony [mailto:tony.luck@intel.com]
> Sent: Tuesday, August 22, 2017 12:03 PM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org;
> rjw@rjwysocki.net; lenb@kernel.org; linux-edac@vger.kernel.org; Borislav
> Petkov <bp@suse.de>
> Subject: Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region
> from Trigger resources
>
> On Tue, Aug 22, 2017 at 02:04:27PM +0000, Ghannam, Yazen wrote:
> > > *einj_get_trigger_parameter_region(
> > > ((char *)trigger_tab + sizeof(struct acpi_einj_trigger));
> > > for (i = 0; i < trigger_tab->entry_count; i++) {
> > > if (entry->action == ACPI_EINJ_TRIGGER_ERROR &&
> > > - entry->instruction == ACPI_EINJ_WRITE_REGISTER_VALUE &&
> > > entry->register_region.space_id ==
> > > ACPI_ADR_SPACE_SYSTEM_MEMORY &&
> > > (entry->register_region.address & param2) == (param1 &
> > > param2))
>
> Maybe you should add the other instruction types that make sense here
> (ACPI_EINJ_READ_REGISTER, ACPI_EINJ_READ_REGISTER_VALUE and
> ACPI_EINJ_WRITE_REGISTER) as a sanity check against the BIOS giving you an
> action in the trigger table that doesn't involve a memory access?
>
Yes, in that case we can do:
entry->instruction <= ACPI_EINJ_WRITE_REGISTER_VALUE
That would cover all the memory access instructions and protect against invalid
instructions.
How does that sound?
Thanks,
Yazen
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RE: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-08-22 16:10 +0200
Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources "Luck, Tony" <tony.luck@intel.com> - 2017-08-22 18:10 +0200
RE: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-08-23 18:40 +0200
Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources "Luck, Tony" <tony.luck@intel.com> - 2017-08-23 19:00 +0200
csiph-web