Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718547

[PATCH v2] fbdev: vgastate: fix line over 80 character and remove unnecessary space

Show all headers | View raw

Fixes the following checkpatch warnings:

WARNING: line over 80 characters
WARNING: space prohibited between function name and open parenthesis '('
WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
 drivers/video/vgastate.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
index 548c751..b17d8e0 100644
--- a/drivers/video/vgastate.c
+++ b/drivers/video/vgastate.c
@@ -31,8 +31,9 @@ struct regstate {
 	__u8 misc;
 };
 
-static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
-				       unsigned char reg)
+static inline unsigned char vga_rcrtcs(void __iomem *regbase,
+					unsigned short iobase,
+					unsigned char reg)
 {
 	vga_w(regbase, iobase + 0x4, reg);
 	return vga_r(regbase, iobase + 0x5);
@@ -454,8 +455,9 @@ int save_vga(struct vgastate *state)
 	}
 	return 0;
 }
+EXPORT_SYMBOL(save_vga);
 
-int restore_vga (struct vgastate *state)
+int restore_vga(struct vgastate *state)
 {
 	if (state->vidstate == NULL)
 		return 1;
@@ -480,8 +482,6 @@ int restore_vga (struct vgastate *state)
 	vga_cleanup(state);
 	return 0;
 }
-
-EXPORT_SYMBOL(save_vga);
 EXPORT_SYMBOL(restore_vga);
 
 MODULE_AUTHOR("James Simmons <jsimmons@users.sf.net>");
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2] fbdev: vgastate: fix line over 80 character and remove unnecessary space Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-23 19:40 +0200

csiph-web