Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Badhri Jagan Sridharan <badhri@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established
Date	Thu, 17 Aug 2017 21:10:03 +0200
Message-ID	<ufyl5-Fn-29@gated-at.bofh.it> (permalink)
References	<ueTrA-7KN-7@gated-at.bofh.it> <ufxfk-8ct-15@gated-at.bofh.it>
X-Original-To	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HB+j5JctX7qJEgjBM9Ro22povqX/N5XSxwOTWDH6+t4=; b=Iv4NmE6M9+B4yqO8RtJcvB8CJ49ZuxpYtQmJ7JR9Xo24AV841sTx+l6Gg2CFtMXnOl wBAYFbU9vZGDroYSoV0S1mLG6W9c/xhRoKw/sczVD1MIlzvAc/VvDNIGObLTWuzSxJnw Pfv3zxmrn7c1r8sgS8hJaWH6K/upC3V1TA+k2Qf0Tr4+nFRJ/2s51f4cemp+nESAh5VK oelDCdGCvJ2yl7lQloI+Qat1Hqcv1CcFvRj03VKhzQcm32GhLXAK+7NYyxLBMzn/AMgR 5jFhiHYRwlGs+y5oJAEFZ6n2fyNFILbw8KTVVzdu58rB1d+Uu/aX/zfGghG5lhUGaayU Vlfw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HB+j5JctX7qJEgjBM9Ro22povqX/N5XSxwOTWDH6+t4=; b=p+PR0tlWfL6UnaobqRbA5pIIBbYkjCZZ7LD4rvl+U3loHoPyzDMkUbbns416vXYnEs yug48qIuALOtRmQJPB5Nr7s8Bj4aKhiq+3FsHChegPZc3wZP3nw1RIR8FvIrT9NMZQeQ 6wPGVhCzj4UztV3A9SlRURVJHkmngPAQ8D8CdlgzbkPoM+MAqZeERwEufVtNaA+E4nPh JOQxm29IlBOBp/bkWJKCpVDCglnY1ZbqvdvsYnUfAr29VEEwon3aU+FHm/fcHiQUSJ6D UxJg0GX9WSKZM0OzOEMAoYFjPEtG3NwhVlGacF3jAkxFoFT8WSDWoEqtykHlCqC7TYY9 XQdg==
X-Gm-Message-State	AHYfb5jHKEmvP03k1reANF0K2zgUVLsmcqcT7DWtCdX/nx4ugl/fdD6g RQKT+gZ5qNCNltWomTbIaAAJHMtOIQc0
X-Received	by 10.202.219.2 with SMTP id s2mr7762669oig.23.1502996853217; Thu, 17 Aug 2017 12:07:33 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Guenter Roeck <linux@roeck-us.net>, devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 17 Aug 2017 12:06:52 -0700
X-Original-Message-ID	<CAPTae5LeXgz=eaU6izq89fLmNG9tuPjNSSpRn6LyNzE4ZD3Zew@mail.gmail.com>
X-Original-References	<20170815232339.26701-1-Badhri@google.com> <20170817175414.GA32163@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1714310

Show key headers only | View raw

Greg,

Sure. Resending the patch based on
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing branch.

Thanks,
Badhri

On Thu, Aug 17, 2017 at 10:54 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Aug 15, 2017 at 04:23:39PM -0700, Badhri Jagan Sridharan wrote:
>> While in SNK_READY state, the explicit_contract seems to be
>> set to true irrespective of whether an explicit contract
>> was established for the current connection. TCPM also seems
>> to report the pwr_opmode as TYPEC_PWR_MODE_PD always once
>> the port gets into SNK_READY state. This isn't completely
>> true as port gets into the SNK_READY state for non-pd
>> type-c ports as well.
>>
>> This patch sets the explicit_contract flag only when
>> the PS_READY message is received and the vbus has been
>> detected by the port controller.
>>
>> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>  drivers/staging/typec/tcpm.c | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> This patch doesn't apply to the tree now that Guenter's other patches
> are applied :(
>
> Please rebase and resend.
>
> thanks,
>
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] staging: typec: tcpm: explicit_contract is always established Badhri Jagan Sridharan <badhri@google.com> - 2017-08-16 01:30 +0200
  Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always  established Guenter Roeck <linux@roeck-us.net> - 2017-08-16 05:40 +0200
  Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always  established Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-17 20:00 +0200
    Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established Badhri Jagan Sridharan <badhri@google.com> - 2017-08-17 21:10 +0200

csiph-web