Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714259

Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established

Show all headers | View raw

On Tue, Aug 15, 2017 at 04:23:39PM -0700, Badhri Jagan Sridharan wrote:
> While in SNK_READY state, the explicit_contract seems to be
> set to true irrespective of whether an explicit contract
> was established for the current connection. TCPM also seems
> to report the pwr_opmode as TYPEC_PWR_MODE_PD always once
> the port gets into SNK_READY state. This isn't completely
> true as port gets into the SNK_READY state for non-pd
> type-c ports as well.
> 
> This patch sets the explicit_contract flag only when
> the PS_READY message is received and the vbus has been
> detected by the port controller.
> 
> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/staging/typec/tcpm.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

This patch doesn't apply to the tree now that Guenter's other patches
are applied :(

Please rebase and resend.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] staging: typec: tcpm: explicit_contract is always established Badhri Jagan Sridharan <badhri@google.com> - 2017-08-16 01:30 +0200
  Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always  established Guenter Roeck <linux@roeck-us.net> - 2017-08-16 05:40 +0200
  Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always  established Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-17 20:00 +0200
    Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established Badhri Jagan Sridharan <badhri@google.com> - 2017-08-17 21:10 +0200

csiph-web