Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power supply device

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power supply device
Date	Thu, 17 Aug 2017 17:20:02 +0200
Message-ID	<ufuKu-6EM-29@gated-at.bofh.it> (permalink)
References	<ud47M-3wS-11@gated-at.bofh.it> <ud47M-3wS-19@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Kv0EX/9ENjqj+L4lFZyXVPIWFaHOl9YIxouuyC5D+28=; b=UBOYh3ByDNvuJ2D9kI7iVj/uStsABe1iS2FjuD1r+cYSFa5wK6WSef7QMKaOGJnWAZ TbzRq7wtamKY1hcEgEGOKsgftaYKWrBB/ALZ3UHzLLdOpwN/zfcJjjuqL9LdSAMz4V9I Nu0J/sibeUCKIYHna6Ni+owGt0vbq2AuQEAS49m3i7h0ds8bv4RxZ+rqgP7Zu3w2MIVe u8EiYtuHasWLqDOL8w8l468tjC371hmcRrpY5m+NI07PVimoYH6xqd/murHACneBi70V eO8ZabnEB76HZjunD92p16J47OG4zm51onPKPBP6RJTLItwFHxT94PSf0yXFCYzs7B4O aP3w==
X-Gm-Message-State	AHYfb5ilrGVitnT7ibyB1JtcCOCrv6PWSkY4FvYtd1R83NrSMG/aeofu dTBXt9BmhcE2fQ==
X-Received	by 10.84.229.6 with SMTP id b6mr6278463plk.274.1502982679490; Thu, 17 Aug 2017 08:11:19 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	linux@roeck-us.net, jdelvare@suse.com, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, joel@jms.id.au, jk@ozlabs.org, andrew@aj.id.au, mark.rutland@arm.com, devicetree@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, "Edward A. James" <eajames@us.ibm.com>
X-Original-Date	Thu, 17 Aug 2017 10:11:16 -0500
X-Original-Message-ID	<20170817151116.4vc4jlna4gc7xzb2@rob-hp-laptop>
X-Original-References	<1502403586-20549-1-git-send-email-eajames@linux.vnet.ibm.com> <1502403586-20549-2-git-send-email-eajames@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1714125

Show key headers only | View raw

On Thu, Aug 10, 2017 at 05:19:44PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
> 
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
>  .../devicetree/bindings/i2c/ibm,power-ps.txt        | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> new file mode 100644
> index 0000000..2ea8ea2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> @@ -0,0 +1,21 @@
> +Device-tree bindings for IBM POWER system power supplies
> +--------------------------------------------------------
> +
> +Required properties:
> + - compatible = "ibm,power-ps";
> + - reg = < I2C bus address >;		: Address of the power supply on the
> +					  I2C bus.
> +
> +Example:
> +
> +    i2c-bus@100 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        #interrupt-cells = <1>;
> +        < more properties >
> +
> +        power_ps@68 {

Don't use '_' in node names. Should be a generic name too if possible. 
Perhaps "power-supply".

> +            compatible = "ibm,power-ps";
> +            reg = <0x68>;
> +        };
> +    };
> -- 
> 1.8.3.1
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power  supply device Rob Herring <robh@kernel.org> - 2017-08-17 17:20 +0200
  Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power  supply device Eddie James <eajames@linux.vnet.ibm.com> - 2017-08-21 20:40 +0200

csiph-web