[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jan Glauber <jglauber@cavium.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset
Date	Thu, 17 Aug 2017 10:20:01 +0200
Message-ID	<ufoc1-29K-3@gated-at.bofh.it> (permalink)
References	<ufoc1-29K-5@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l/LoCL2lhUNZ1BLafGDC+kBuQZaRjOetVe57J3MOTNc=; b=V7H7hgjTpifp6ppvtfRMjkSn7Cw6KjpI/rpSD1xBZP/g3VhDVaq24wlISCkKm7iLiu TBGWOQJNcZ6z1poJe5PzhNLrIbhy56LrdNmv4axhNwCmiGvsIDcLI3XnO0KjGMJBRAqL yHZur3tTmLd/K737VItQmAClxGM29mA6li0MeNGtC3itd3kcP1i/p4DEyVMolQCx2DBR NdZ1QlxUewIsBcypD5DsRJV2xUXh6E4WZB6dtuU5I5ncY34atrrmWC3Wp7EFhztlp8M4 N5IP3+xtZEJuh3/NEFCRvPuzJT70kVTGILf7bUm68AljUvOWeYEliL9IGFRSoZ8seSPk 0I/w==
X-Gm-Message-State	AHYfb5jb012+3B9DrTzu1qDzALzYLxpSU5O+iWAs4nCbzJFYMCR9QvUe gIK4AL5KXuI7cg==
X-Received	by 10.223.170.140 with SMTP id h12mr2685615wrc.79.1502957705644; Thu, 17 Aug 2017 01:15:05 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, david.daney@cavium.com, Jon Masters <jcm@redhat.com>, Robert Richter <robert.richter@cavium.com>, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Jan Glauber <jglauber@cavium.com>
X-Original-Date	Thu, 17 Aug 2017 10:14:23 +0200
X-Original-Message-ID	<1502957663-5527-4-git-send-email-jglauber@cavium.com>
X-Original-References	<1502957663-5527-1-git-send-email-jglauber@cavium.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1713655

Show key headers only | View raw

If a PCI device supports neither function-level reset, nor slot
or bus reset then refuse to probe it. A line is printed to inform
the user.

Without this change starting qemu with a vfio-pci device can lead to
a kernel panic on some Cavium cn8xxx systems, depending on the used
device.

Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
 drivers/vfio/pci/vfio_pci.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index 063c1ce..029ba13 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -1196,6 +1196,12 @@ static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	if (pdev->hdr_type != PCI_HEADER_TYPE_NORMAL)
 		return -EINVAL;
 
+	ret = pci_probe_reset_bus(pdev->bus);
+	if (ret) {
+		dev_warn(&pdev->dev, "Refusing to probe because reset is not possible.\n");
+		return ret;
+	}
+
 	group = vfio_iommu_group_get(&pdev->dev);
 	if (!group)
 		return -EINVAL;
-- 
2.9.0.rc0.21.g7777322

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset Jan Glauber <jglauber@cavium.com> - 2017-08-17 10:20 +0200
  Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be  reset Alex Williamson <alex.williamson@redhat.com> - 2017-08-17 15:10 +0200
    Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be  reset Alex Williamson <alex.williamson@redhat.com> - 2017-08-18 16:20 +0200
      Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be  reset Alex Williamson <alex.williamson@redhat.com> - 2017-08-19 06:00 +0200

csiph-web