[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

From	Jan Glauber <jglauber@cavium.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset
Date	2017-08-17 10:20 +0200
Message-ID	<ufoc1-29K-3@gated-at.bofh.it> (permalink)
References	<ufoc1-29K-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

If a PCI device supports neither function-level reset, nor slot
or bus reset then refuse to probe it. A line is printed to inform
the user.

Without this change starting qemu with a vfio-pci device can lead to
a kernel panic on some Cavium cn8xxx systems, depending on the used
device.

Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
 drivers/vfio/pci/vfio_pci.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index 063c1ce..029ba13 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -1196,6 +1196,12 @@ static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	if (pdev->hdr_type != PCI_HEADER_TYPE_NORMAL)
 		return -EINVAL;
 
+	ret = pci_probe_reset_bus(pdev->bus);
+	if (ret) {
+		dev_warn(&pdev->dev, "Refusing to probe because reset is not possible.\n");
+		return ret;
+	}
+
 	group = vfio_iommu_group_get(&pdev->dev);
 	if (!group)
 		return -EINVAL;
-- 
2.9.0.rc0.21.g7777322

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset Jan Glauber <jglauber@cavium.com> - 2017-08-17 10:20 +0200
  Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be  reset Alex Williamson <alex.williamson@redhat.com> - 2017-08-17 15:10 +0200
    Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be  reset Alex Williamson <alex.williamson@redhat.com> - 2017-08-18 16:20 +0200
      Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be  reset Alex Williamson <alex.williamson@redhat.com> - 2017-08-19 06:00 +0200

csiph-web