Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1715511

Re: [PATCH] staging: lustre: fix structure size for ARM OABI

From "Dilger, Andreas" <andreas.dilger@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: lustre: fix structure size for ARM OABI
Date 2017-08-19 02:00 +0200
Message-ID <ufZlf-28T-1@gated-at.bofh.it> (permalink)
References <uf7NU-8hY-17@gated-at.bofh.it> <ufvQe-7mK-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Aug 17, 2017, at 10:26, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote:
>> When building the kernel for the ARM architecture without setting
>> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3
>> differs, due to different alignment requirements of OABI and EABI.
>> 
>> Marking the anonymous union within struct lov_user_md_v3 as
>> '_packed' solves this issue. Otherwise we get the following
>> error:
>> 
>> drivers/staging/lustre/lustre/lov/lov_pack.c:352:2: note: in expansion
>> of macro ‘BUILD_BUG_ON’
>>  BUILD_BUG_ON(sizeof(lum) != sizeof(struct lov_mds_md_v3));
>> 
>> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This file is no longer in the tree :(

With James' recent patch series, this has moved to include/uapi/linux/lustre/lustre_user.h

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: lustre: fix structure size for ARM OABI Cihangir Akturk <cakturk@gmail.com> - 2017-08-16 16:50 +0200
  Re: [PATCH] staging: lustre: fix structure size for ARM OABI Greg KH <gregkh@linuxfoundation.org> - 2017-08-17 18:30 +0200
    Re: [PATCH] staging: lustre: fix structure size for ARM OABI "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-08-19 02:00 +0200
      Re: [PATCH] staging: lustre: fix structure size for ARM OABI James Simmons <jsimmons@infradead.org> - 2017-08-20 05:00 +0200
        Re: [PATCH] staging: lustre: fix structure size for ARM OABI Cihangir Akturk <cakturk@gmail.com> - 2017-08-21 14:40 +0200

csiph-web