Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713018

[PATCH] staging: lustre: fix structure size for ARM OABI

Show all headers | View raw

When building the kernel for the ARM architecture without setting
CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3
differs, due to different alignment requirements of OABI and EABI.

Marking the anonymous union within struct lov_user_md_v3 as
'_packed' solves this issue. Otherwise we get the following
error:

drivers/staging/lustre/lustre/lov/lov_pack.c:352:2: note: in expansion
of macro ‘BUILD_BUG_ON’
  BUILD_BUG_ON(sizeof(lum) != sizeof(struct lov_mds_md_v3));

Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
 drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index edff8dc..4f72cb6 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -388,7 +388,7 @@ struct lov_user_md_v3 {	   /* LOV EA user data (host-endian) */
 		__u16 lmm_layout_gen;     /* layout generation number
 					   * used when reading
 					   */
-	};
+	} __packed;
 	char  lmm_pool_name[LOV_MAXPOOLNAME + 1];   /* pool name */
 	struct lov_user_ost_data_v1 lmm_objects[0]; /* per-stripe data */
 } __packed;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: fix structure size for ARM OABI Cihangir Akturk <cakturk@gmail.com> - 2017-08-16 16:50 +0200
  Re: [PATCH] staging: lustre: fix structure size for ARM OABI Greg KH <gregkh@linuxfoundation.org> - 2017-08-17 18:30 +0200
    Re: [PATCH] staging: lustre: fix structure size for ARM OABI "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-08-19 02:00 +0200
      Re: [PATCH] staging: lustre: fix structure size for ARM OABI James Simmons <jsimmons@infradead.org> - 2017-08-20 05:00 +0200
        Re: [PATCH] staging: lustre: fix structure size for ARM OABI Cihangir Akturk <cakturk@gmail.com> - 2017-08-21 14:40 +0200

csiph-web