Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver
Date	2017-08-16 17:40 +0200
Message-ID	<uf8Ai-mw-7@gated-at.bofh.it> (permalink)
References	<ueUxj-8pZ-9@gated-at.bofh.it> <ueUxk-8pZ-27@gated-at.bofh.it> <uf37A-5nW-23@gated-at.bofh.it> <uf5j4-6Uh-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-08-16 at 14:09 +0200, Andreas Färber wrote:
> Hi Philipp,
> 
> Am 16.08.2017 um 11:44 schrieb Philipp Zabel:
> > On Wed, 2017-08-16 at 02:38 +0200, Andreas Färber wrote:
> > > Add a per-register reset controller driver. This deals with the
> > > fact
> > > that not all registers are adjoined.
> > 
> > the way you handle the non-contiguous reset registers, this looks
> > like
> > a candidate to join the recently discussed reset-simple driver [1].
> > Could you check if that would fit?
> 
> Thanks, I appreciate the idea, and it looks like you already have the
> active-low logic in place.
> 
> Are you okay with keeping the first three as separate nodes, or would
> you rather want one node to cover the first three registers, plus two
> separate ones for the non-contiguous cases?

I am fine with keeping them separate, if you think this best describes
the hardware.

> Or is the simple driver supposed to cover gaps, too? Then we could go
> with just two nodes. (I found it weird to have reset and then reset4,
> so I went with separate ones as seen downstream.)

I had declared gaps as out of scope of the simple reset controller
driver, but if the implementation could be kept reasonably simple, we
could think about supporting something like this, too:

		reset: reset-controller@98000000 {
			compatible = "realtek,rtd1295-reset";
			reg = <0x98000000 0xc>, <0x98000050 0x4>;
			#reset-cells = <1>;
		};

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] reset: Add Realtek RTD1295 driver Andreas Färber <afaerber@suse.de> - 2017-08-16 02:40 +0200
  Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 11:50 +0200
    Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver Andreas Färber <afaerber@suse.de> - 2017-08-16 14:10 +0200
      Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-16 17:40 +0200

csiph-web