Re: [PATCH] IB/core: fix memory leak on ah on error return path

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/core: fix memory leak on ah on error return path
Date	2017-08-16 17:40 +0200
Message-ID	<uf8Ai-mw-5@gated-at.bofh.it> (permalink)
References	<uc9Me-6Rb-19@gated-at.bofh.it> <uc9VT-6Xw-5@gated-at.bofh.it> <uc9VT-6Xw-13@gated-at.bofh.it> <ucch5-8wk-39@gated-at.bofh.it> <uciFQ-4Mx-23@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

On Tue, 2017-08-08 at 19:48 +0000, Parav Pandit wrote:
> Hi,
> 
> I need to top post because comments are unrelated to past discussion.
> 
> rdma_ah_retrieve_dmac() can never fail for RoCE as its returning
> pointer from structure ah_attr.
> Provider driver doesn't need to check for null pointer as ib/core
> would never call provider if it's not RoCE provider.
> So this memory leak only exist in theory.
> 
> When its null, driver should WARN_ON/BUG_ON in extreme case, but
> that's not necessary either.
> 
> I have patch is progress under internal review that does nice small
> cleanup in many provider drivers that eliminates the check
> completely.
> Waiting for Moni to finish the review.

This sounds like a nice patch to push into for-next, but in the
meantime I took the V2 of this patch as it silences a checker warning.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] IB/core: fix memory leak on ah on error return path Doug Ledford <dledford@redhat.com> - 2017-08-16 17:40 +0200

csiph-web