Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating snapshot

From	Chen Yu <yu.c.chen@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating snapshot
Date	2017-08-16 16:40 +0200
Message-ID	<uf7Ee-8eC-7@gated-at.bofh.it> (permalink)
References	<ueYAV-2vJ-13@gated-at.bofh.it> <uf5M6-73I-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 16, 2017 at 02:33:59PM +0200, Michal Hocko wrote:
> On Wed 16-08-17 12:53:38, Chen Yu wrote:
> [...]
> > @@ -2537,10 +2538,15 @@ void mark_free_pages(struct zone *zone)
> >  	unsigned long flags;
> >  	unsigned int order, t;
> >  	struct page *page;
> > +	bool wd_suspended;
> >  
> >  	if (zone_is_empty(zone))
> >  		return;
> >  
> > +	wd_suspended = lockup_detector_suspend() ? false : true;
> > +	if (!wd_suspended)
> > +		pr_warn_once("Failed to disable lockup detector during hibernation.\n");
> > +
> >  	spin_lock_irqsave(&zone->lock, flags);
> >  
> >  	max_zone_pfn = zone_end_pfn(zone);
> 
> I am not maintainer of this code so I am not very familiar with the full
> context of this function but lockup_detector_suspend is just too heavy
> for the purpose you are trying to achive. Really why don't you just
> poke the watchdog every N pages?
OK, I'll send another version.
Thanks,
	Yu
> -- 
> Michal Hocko
> SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating snapshot Chen Yu <yu.c.chen@intel.com> - 2017-08-16 07:00 +0200
  Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating  snapshot Michal Hocko <mhocko@kernel.org> - 2017-08-16 14:40 +0200
    Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating  snapshot Chen Yu <yu.c.chen@intel.com> - 2017-08-16 16:40 +0200

csiph-web