Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712914

Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating snapshot

Show all headers | View raw

On Wed 16-08-17 12:53:38, Chen Yu wrote:
[...]
> @@ -2537,10 +2538,15 @@ void mark_free_pages(struct zone *zone)
>  	unsigned long flags;
>  	unsigned int order, t;
>  	struct page *page;
> +	bool wd_suspended;
>  
>  	if (zone_is_empty(zone))
>  		return;
>  
> +	wd_suspended = lockup_detector_suspend() ? false : true;
> +	if (!wd_suspended)
> +		pr_warn_once("Failed to disable lockup detector during hibernation.\n");
> +
>  	spin_lock_irqsave(&zone->lock, flags);
>  
>  	max_zone_pfn = zone_end_pfn(zone);

I am not maintainer of this code so I am not very familiar with the full
context of this function but lockup_detector_suspend is just too heavy
for the purpose you are trying to achive. Really why don't you just
poke the watchdog every N pages?
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating snapshot Chen Yu <yu.c.chen@intel.com> - 2017-08-16 07:00 +0200
  Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating  snapshot Michal Hocko <mhocko@kernel.org> - 2017-08-16 14:40 +0200
    Re: [PATCH][RFC v2] PM / Hibernate: Disable wathdog when creating  snapshot Chen Yu <yu.c.chen@intel.com> - 2017-08-16 16:40 +0200

csiph-web