Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712727
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: ncr5380: constify pnp_device_id |
| Date | 2017-08-16 09:20 +0200 |
| Message-ID | <uf0Mp-42X-1@gated-at.bofh.it> (permalink) |
| References | <ueYAV-2vJ-3@gated-at.bofh.it> <ueYAV-2vJ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 16 Aug 2017, Arvind Yadav wrote:
> pnp_device_id are not supposed to change at runtime. All functions
> working with pnp_device_id provided by <linux/pnp.h> work with
> const pnp_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/g_NCR5380.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
> index c34fc91..1968d81 100644
> --- a/drivers/scsi/g_NCR5380.c
> +++ b/drivers/scsi/g_NCR5380.c
> @@ -703,7 +703,7 @@ static struct isa_driver generic_NCR5380_isa_driver = {
> };
>
> #ifdef CONFIG_PNP
> -static struct pnp_device_id generic_NCR5380_pnp_ids[] = {
> +static const struct pnp_device_id generic_NCR5380_pnp_ids[] = {
> { .id = "DTC436e", .driver_data = BOARD_DTC3181E },
> { .id = "" }
> };
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scsi: ncr5380: constify pnp_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-16 07:00 +0200 Re: [PATCH] scsi: ncr5380: constify pnp_device_id Finn Thain <fthain@telegraphics.com.au> - 2017-08-16 09:20 +0200 Re: [PATCH] scsi: ncr5380: constify pnp_device_id "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-17 03:00 +0200
csiph-web