[PATCH] scsi: ncr5380: constify pnp_device_id

From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] scsi: ncr5380: constify pnp_device_id
Date	2017-08-16 07:00 +0200
Message-ID	<ueYAV-2vJ-1@gated-at.bofh.it> (permalink)
References	<ueYAV-2vJ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

pnp_device_id are not supposed to change at runtime. All functions
working with pnp_device_id provided by <linux/pnp.h> work with
const pnp_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/scsi/g_NCR5380.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index c34fc91..1968d81 100644
--- a/drivers/scsi/g_NCR5380.c
+++ b/drivers/scsi/g_NCR5380.c
@@ -703,7 +703,7 @@ static struct isa_driver generic_NCR5380_isa_driver = {
 };
 
 #ifdef CONFIG_PNP
-static struct pnp_device_id generic_NCR5380_pnp_ids[] = {
+static const struct pnp_device_id generic_NCR5380_pnp_ids[] = {
 	{ .id = "DTC436e", .driver_data = BOARD_DTC3181E },
 	{ .id = "" }
 };
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: ncr5380: constify pnp_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-16 07:00 +0200
  Re: [PATCH] scsi: ncr5380: constify pnp_device_id Finn Thain <fthain@telegraphics.com.au> - 2017-08-16 09:20 +0200
  Re: [PATCH] scsi: ncr5380: constify pnp_device_id "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-17 03:00 +0200

csiph-web