Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1711584
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask |
| Date | 2017-08-15 03:00 +0200 |
| Message-ID | <ueyn7-2Jw-5@gated-at.bofh.it> (permalink) |
| References | <ue73A-2MD-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Aug 13, 2017 at 09:43:50PM +0200, Frederico Cadete wrote: > The code was using the logical negation operator "!", effectively never > triggering the error path. To check the bitmask we should use the > bitwise negation "~". > > Cleans up sparse warning: > warning: dubious: x & !y > > Signed-off-by: Frederico Cadete <frederico@cadete.eu> > --- > drivers/staging/pi433/rf69.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does not apply to my tree :(
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] staging: pi433: fix check for FDEVMSB register mask Frederico Cadete <frederico@cadete.eu> - 2017-08-13 21:50 +0200 Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask Greg KH <gregkh@linuxfoundation.org> - 2017-08-15 03:00 +0200
csiph-web