[PATCH] staging: pi433: fix check for FDEVMSB register mask

From	Frederico Cadete <frederico@cadete.eu>
Newsgroups	linux.kernel
Subject	[PATCH] staging: pi433: fix check for FDEVMSB register mask
Date	2017-08-13 21:50 +0200
Message-ID	<ue73A-2MD-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The code was using the logical negation operator "!", effectively never
triggering the error path. To check the bitmask we should use the
bitwise negation "~".

Cleans up sparse warning:
  warning: dubious: x & !y

Signed-off-by: Frederico Cadete <frederico@cadete.eu>
---
 drivers/staging/pi433/rf69.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index f83523e3395d..e6332e1297ae 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -203,7 +203,7 @@ int rf69_set_deviation(struct spi_device *spi, u32 deviation)
 	lsb = (f_reg&0xff);
 
 	// check msb
-	if (msb & !FDEVMASB_MASK)
+	if (msb & ~FDEVMASB_MASK)
 	{
 		dev_dbg(&spi->dev, "set_deviation: err in calc of msb");
 		INVALID_PARAM;
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: pi433: fix check for FDEVMSB register mask Frederico Cadete <frederico@cadete.eu> - 2017-08-13 21:50 +0200
  Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask Greg KH <gregkh@linuxfoundation.org> - 2017-08-15 03:00 +0200

csiph-web