RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer

From	Tom Talpey <ttalpey@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer
Date	2017-08-14 23:20 +0200
Message-ID	<ueuWd-Mv-7@gated-at.bofh.it> (permalink)
References	<ua8hz-6jk-3@gated-at.bofh.it> <ua8hD-6jk-75@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs-
> owner@vger.kernel.org] On Behalf Of Long Li
> Sent: Wednesday, August 2, 2017 4:11 PM
> To: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org
> Cc: Long Li <longli@microsoft.com>
> Subject: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer
> 
> +static int keep_alive_interval = 120;

This is the recommended value, but not the only possibility.

> @@ -1348,6 +1369,10 @@ struct cifs_rdma_info* cifs_create_rdma_session(
>         init_waitqueue_head(&info->wait_send_queue);
>         init_waitqueue_head(&info->wait_reassembly_queue);
> 
> +       INIT_DELAYED_WORK(&info->idle_timer_work, idle_connection_timer);
> +       schedule_delayed_work(&info->idle_timer_work,
> +               info->keep_alive_interval*HZ);
> +

This initialization is ok, but the timer should be rescheduled (extended) any time
any packet is sent. There is no need to perform keepalives on an active SMB Direct
connection.

Tom.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection  timer Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 23:20 +0200
  RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection  timer Long Li <longli@microsoft.com> - 2017-08-15 01:30 +0200
    RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection  timer Tom Talpey <ttalpey@microsoft.com> - 2017-08-15 01:50 +0200
      RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection  timer Long Li <longli@microsoft.com> - 2017-08-15 02:20 +0200

csiph-web