Re: [PATCH 3/3] x86/intel_rdt/cqm: Improve limbo list processing

From	Shivappa Vikas <vikas.shivappa@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] x86/intel_rdt/cqm: Improve limbo list processing
Date	2017-08-14 23:20 +0200
Message-ID	<ueuWd-Mv-5@gated-at.bofh.it> (permalink)
References	<ucEdj-2Fa-7@gated-at.bofh.it> <ucEdj-2Fa-5@gated-at.bofh.it> <uekav-2tS-35@gated-at.bofh.it> <uet46-86q-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Mon, 14 Aug 2017, Shivappa Vikas wrote:

>
>
> On Mon, 14 Aug 2017, Thomas Gleixner wrote:
>
>> On Wed, 9 Aug 2017, Vikas Shivappa wrote:
>> 
>>> @@ -426,6 +426,9 @@ static int domain_setup_mon_state(struct rdt_resource 
>>> *r, struct rdt_domain *d)
>>>  					   GFP_KERNEL);
>>>  		if (!d->rmid_busy_llc)
>>>  			return -ENOMEM;
>>> +		INIT_DELAYED_WORK(&d->cqm_limbo, cqm_handle_limbo);
>>> +		if (has_busy_rmid(r, d))
>>> +			cqm_setup_limbo_handler(d);
>> 
>> This is beyond silly. d->rmid_busy_llc is allocated a few lines above. How
>> would a bit be set here?
>
> If we logically offline all cpus in a package and bring it back, the worker 
> needs to be scheduled on the package if there were busy RMIDs on this 
> package. Otherwise that RMID never gets freed as its rmid->busy stays 1..
>
> I needed to scan the limbo list and set the bits for all limbo RMIDs after 
> the alloc and before doing the 'has_busy_rmid' check. Will fix

Tony pointed out that there is no guarentee that a domain will come back up once 
its down, so the above issue of rmid->busy staying at > 0 can still happen. 
So I will delete this -
 		if (has_busy_rmid(r, d))
 			cqm_setup_limbo_handler(d);

and add this when a domain is powered down -
 	for each rmid in d->rmid_busy_llc
 		if (--entry->busy)
 			free_rmid(rmid);

We have no way to know if the L3 was indeed flushed (or package was powered 
off). This may lead to incorrect counts in rare scenarios but can document the 
same.

Thanks,
vikas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] x86/intel_rdt/cqm: Improve limbo list processing Thomas Gleixner <tglx@linutronix.de> - 2017-08-14 11:50 +0200
  Re: [PATCH 3/3] x86/intel_rdt/cqm: Improve limbo list processing Shivappa Vikas <vikas.shivappa@intel.com> - 2017-08-14 21:20 +0200
    Re: [PATCH 3/3] x86/intel_rdt/cqm: Improve limbo list processing Shivappa Vikas <vikas.shivappa@intel.com> - 2017-08-14 23:20 +0200

csiph-web