Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1711022

Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support

From Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support
Date 2017-08-14 17:30 +0200
Message-ID <ueptx-5Ok-25@gated-at.bofh.it> (permalink)
References <uadqV-1dX-15@gated-at.bofh.it> <uadqV-1dX-21@gated-at.bofh.it> <uelgd-389-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Adrian,


2017-08-14 19:53 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:

>> @@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>>       return ret;
>>  }
>>
>> +static int __maybe_unused sdhci_cdns_resume(struct device *dev)
>
> We don't use __maybe_unused in this case, we use #ifdef CONFIG_PM_SLEEP


Could you tell me the reason
why #ifdef CONFIG_PM_SLEEP is preferable?

I see lots of __maybe_unused for suspend/resume hooks in drivers.


-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Adrian Hunter <adrian.hunter@intel.com> - 2017-08-14 13:00 +0200
  Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-14 17:30 +0200
    Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Adrian Hunter <adrian.hunter@intel.com> - 2017-08-15 09:00 +0200

csiph-web