Groups > linux.kernel > #1711911

Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support

From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support
Date	2017-08-15 09:00 +0200
Message-ID	<ueDZw-6mv-11@gated-at.bofh.it> (permalink)
References	<uadqV-1dX-15@gated-at.bofh.it> <uadqV-1dX-21@gated-at.bofh.it> <uelgd-389-7@gated-at.bofh.it> <ueptx-5Ok-25@gated-at.bofh.it>
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw

On 14/08/17 18:28, Masahiro Yamada wrote:
> Hi Adrian,
> 
> 
> 2017-08-14 19:53 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
> 
>>> @@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>>>       return ret;
>>>  }
>>>
>>> +static int __maybe_unused sdhci_cdns_resume(struct device *dev)
>>
>> We don't use __maybe_unused in this case, we use #ifdef CONFIG_PM_SLEEP
> 
> 
> Could you tell me the reason
> why #ifdef CONFIG_PM_SLEEP is preferable?
> 
> I see lots of __maybe_unused for suspend/resume hooks in drivers.

Not in sdhci drivers.  It is easier for the maintainer to have consistency
across the code they maintain.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Adrian Hunter <adrian.hunter@intel.com> - 2017-08-14 13:00 +0200
  Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-14 17:30 +0200
    Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Adrian Hunter <adrian.hunter@intel.com> - 2017-08-15 09:00 +0200

csiph-web