Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710605

Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108

Show all headers | View raw

Hi Heiko:


On 2017年08月13日 20:13, Heiko Stuebner wrote:
> Hi Andy,
>
> Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
>> Add saradc device tree node for rv1108 soc
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> +	adc: adc@1038c000 {
>> +		compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
>> +		reg = <0x1038c000 0x100>;
>> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>> +		#io-channel-cells = <1>;
>> +		io-channel-ranges;
> What do you need the io-channel-ranges for?
> I.e. according to the documenation it is meant for when the adc is also
> a "bus node" and has children that should inherit channels from it.
>
> In all saradc uses so far we only have separate nodes referencing the
> adc controller (like adc-keys etc), so this does not look like it is needed?

     Sorry, I just copied it from the downstream dts. After checked with 
David, he suggested that we could remove it.
>
>
> Heiko
>
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-13 14:20 +0200
  Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for  rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-14 03:50 +0200

csiph-web