Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710495

Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108

Show all headers | View raw

Hi Andy,

Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108 soc
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> 

> +	adc: adc@1038c000 {
> +		compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
> +		reg = <0x1038c000 0x100>;
> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +		#io-channel-cells = <1>;
> +		io-channel-ranges;

What do you need the io-channel-ranges for?
I.e. according to the documenation it is meant for when the adc is also
a "bus node" and has children that should inherit channels from it.

In all saradc uses so far we only have separate nodes referencing the
adc controller (like adc-keys etc), so this does not look like it is needed?


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/13] Support more devices on rockchip rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:40 +0200
  [PATCH v3 02/13] i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:40 +0200
    Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108 Wolfram Sang <wsa@the-dreams.de> - 2017-08-12 16:10 +0200
      Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108 Wolfram Sang <wsa@the-dreams.de> - 2017-08-12 16:40 +0200
    Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108 Wolfram Sang <wsa@the-dreams.de> - 2017-08-12 16:50 +0200
  [PATCH v3 08/13] ARM: dts: rockchip: add watchdog dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
    Re: [PATCH v3 08/13] ARM: dts: rockchip: add watchdog dt node for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-13 14:20 +0200
  [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
    Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-13 14:20 +0200
      Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for  rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-14 03:50 +0200
  [PATCH v3 04/13] spi: rockchip: add compatible string for rv1108 spi Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
  [PATCH v3 03/13] ARM: dts: rockchip: add i2c dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
    Re: [PATCH v3 03/13] ARM: dts: rockchip: add i2c dt node for rv1108 Wolfram Sang <wsa@the-dreams.de> - 2017-08-12 16:50 +0200
      Re: [PATCH v3 03/13] ARM: dts: rockchip: add i2c dt node for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-13 14:10 +0200
  [PATCH v3 05/13] ARM: dts: rockchip: add spi dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
  [PATCH v3 05/13] ARM: dts: rockchip: add spi dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
  [PATCH v3 11/13] ARM: dts: rockchip: add pwm backlight for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
  [PATCH v3 07/13] ARM: dts: rockchip: add pwm dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
  [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
    Re: [PATCH v3 09/13] dt-bindings: adc: add description for rv1108  saradc Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-08-12 14:50 +0200
  [PATCH v3 06/13] dt-bindings: pwm: add description for rv1108 pwm Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
    Re: [PATCH v3 06/13] dt-bindings: pwm: add description for rv1108 pwm Heiko Stuebner <heiko@sntech.de> - 2017-08-13 13:00 +0200
  [PATCH v3 13/13] ARM: dts: rockchip: add accelerometer bma250e dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200
    Re: [PATCH v3 13/13] ARM: dts: rockchip: add accelerometer bma250e dt node for rv1108 evb Heiko Stuebner <heiko@sntech.de> - 2017-08-13 14:20 +0200
  [PATCH v3 12/13] ARM: dts: rockchip: add pmic rk805 dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-08-11 05:50 +0200

csiph-web