Re: [PATCH 2/5] net/9p: Improve 19 size determinations

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] net/9p: Improve 19 size determinations
Date	2017-08-15 16:30 +0200
Message-ID	<ueL10-2pR-13@gated-at.bofh.it> (permalink)
References	<ueIFQ-RA-17@gated-at.bofh.it> <ueIPw-19O-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 15, 2017 at 02:00:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 15 Aug 2017 09:36:20 +0200
> 
> Replace the specification of data structures by variable references
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.

Garbage.  This makes it so much harder to find where the objects of given
type are created.  It's _not_ safer and any patches of that sort around
VFS will be shitcanned.  What to do with net/9p patches is up to net/9p
maintainers, but I would strongly recommend the same treatment.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] net/9p: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:00 +0200
  [PATCH 4/5] net/9p: Adjust a jump target in p9_client_attach() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
  [PATCH 5/5] net/9p: Delete an unnecessary variable initialisation in  p9_client_attach() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
  [PATCH 3/5] net/9p: Add a jump target in p9_client_walk() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
  [PATCH 2/5] net/9p: Improve 19 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
    Re: [PATCH 2/5] net/9p: Improve 19 size determinations Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-15 16:30 +0200

csiph-web