Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712122

[PATCH 3/5] net/9p: Add a jump target in p9_client_walk()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 15 Aug 2017 10:07:22 +0200

Replace a variable assignment by a goto statement so that an extra check
will be avoided at the end of this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/9p/client.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/9p/client.c b/net/9p/client.c
index 2ca55d4b0b7d..6c2fc796edfb 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -1237,12 +1237,11 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname,
 clunk_fid:
 	kfree(wqids);
 	p9_client_clunk(fid);
-	fid = NULL;
-
+	goto exit;
 error:
 	if (fid && (fid != oldfid))
 		p9_fid_destroy(fid);
-
+exit:
 	return ERR_PTR(err);
 }
 EXPORT_SYMBOL(p9_client_walk);
-- 
2.14.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] net/9p: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:00 +0200
  [PATCH 4/5] net/9p: Adjust a jump target in p9_client_attach() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
  [PATCH 5/5] net/9p: Delete an unnecessary variable initialisation in  p9_client_attach() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
  [PATCH 3/5] net/9p: Add a jump target in p9_client_walk() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
  [PATCH 2/5] net/9p: Improve 19 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-15 14:10 +0200
    Re: [PATCH 2/5] net/9p: Improve 19 size determinations Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-15 16:30 +0200

csiph-web