Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710199

Re: [PATCH 0/6] constify pci_error_handlers structures

From Julia Lawall <julia.lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [PATCH 0/6] constify pci_error_handlers structures
Date 2017-08-12 10:00 +0200
Message-ID <udzuV-6cl-3@gated-at.bofh.it> (permalink)
References <udxW9-5qW-3@gated-at.bofh.it> <udzlf-69b-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 12 Aug 2017, Christoph Hellwig wrote:

> On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote:
> > These pci_error_handlers structures are only stored in the err_handler
> > field of a pci_driver structure, and this field is declared as const.  Thus
> > the pci_error_handlers structures can be const too.
> >
> > Done with the help of Coccinelle.
>
> If you're doing a scripted conversion of the pci_error_handlers
> structured I'd much rather see that structure killed off and folded
> into the pci_driver one.

OK, sure.  So to be precise, you want the fields error_detected,
mmio_enabled, etc to be added as new fields to the pci_driver structure?

They both have a resume field, though.  What should the pci_error_handlers
resume function be renamed to?  Would resume_after_error be too much?

julia

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  [PATCH 5/6] [SCSI] csiostor: constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  [PATCH 6/6] bfa: constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  [PATCH 2/6] GenWQE: constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  Re: [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig <hch@infradead.org> - 2017-08-12 09:50 +0200
    Re: [PATCH 0/6] constify pci_error_handlers structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-12 10:00 +0200
      Re: [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig <hch@infradead.org> - 2017-08-12 10:00 +0200
        Re: [PATCH 0/6] constify pci_error_handlers structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-12 10:10 +0200
        Re: [PATCH 0/6] constify pci_error_handlers structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-12 14:00 +0200
          Re: [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig <hch@infradead.org> - 2017-08-13 16:40 +0200

csiph-web