Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710243

Re: [PATCH 0/6] constify pci_error_handlers structures

From Julia Lawall <julia.lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [PATCH 0/6] constify pci_error_handlers structures
Date 2017-08-12 14:00 +0200
Message-ID <udDfb-fj-9@gated-at.bofh.it> (permalink)
References <udxW9-5qW-3@gated-at.bofh.it> <udzlf-69b-5@gated-at.bofh.it> <udzuV-6cl-3@gated-at.bofh.it> <udzuV-6cl-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and
drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers
structure is defined in one file and used in another file.  The structure
definition references various functions that are static in the same file.
Should I try to move those functions to the file containing the pci_driver
structure?  Or leave the functions where they are and remove the static
annotation?

thanks,
julia

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  [PATCH 5/6] [SCSI] csiostor: constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  [PATCH 6/6] bfa: constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  [PATCH 2/6] GenWQE: constify pci_error_handlers structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:20 +0200
  Re: [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig <hch@infradead.org> - 2017-08-12 09:50 +0200
    Re: [PATCH 0/6] constify pci_error_handlers structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-12 10:00 +0200
      Re: [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig <hch@infradead.org> - 2017-08-12 10:00 +0200
        Re: [PATCH 0/6] constify pci_error_handlers structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-12 10:10 +0200
        Re: [PATCH 0/6] constify pci_error_handlers structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-12 14:00 +0200
          Re: [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig <hch@infradead.org> - 2017-08-13 16:40 +0200

csiph-web