Re: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport
Date	2017-08-12 21:00 +0200
Message-ID	<udJND-4BC-5@gated-at.bofh.it> (permalink)
References	<ua8hz-6jk-3@gated-at.bofh.it> <ua8rg-6nd-7@gated-at.bofh.it> <uc6On-4zt-27@gated-at.bofh.it> <udA7H-6G3-83@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 12, 2017 at 08:32:48AM +0000, Long Li via samba-technical wrote:
> I think it is possible to separate the common code that implements the SMBDirect transport. There are some challenges to reuse the same code for both kernel and user spaces.
> 1. Kernel mode RDMA verbs are similar but different to user-mode ones.
> 2. Some RDMA features (e.g Fast Registration Work Request) are not available in user-mode.
> 3. Locking and synchronization mechanism is different
> 4. Memory management is different.
> 5. Process creation/scheduling and data sharing between processes are different, and there is no user-mode code running in interrupt/softirq.
> 
> Those needs to be abstracted through a layer, the rest of the code can be shared. I can work on this after patch set is reviewed.

NAK - code with those sort of obsfucation layer will be rejected
for kernel inclusion - don't add it.

Thread

[[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:20 +0200
  [[PATCH v1] 19/37] [CIFS] SMBD: Manage credits on SMBD client and server Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:20 +0200
    RE: [[PATCH v1] 19/37] [CIFS] SMBD: Manage credits on SMBD client and  server Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 22:50 +0200
      RE: [[PATCH v1] 19/37] [CIFS] SMBD: Manage credits on SMBD client and  server Long Li <longli@microsoft.com> - 2017-08-15 01:10 +0200
  [[PATCH v1] 08/37] [CIFS] SMBD: Define packet format for SMBD data transfer message Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    Re: [[PATCH v1] 08/37] [CIFS] SMBD: Define packet format for SMBD  data transfer message Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:20 +0200
      Re: [[PATCH v1] 08/37] [CIFS] SMBD: Define packet format for SMBD  data transfer message Jeff Layton <jlayton@redhat.com> - 2017-08-14 12:30 +0200
  [[PATCH v1] 11/37] [CIFS] SMBD: Post a receive request Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    Re: [[PATCH v1] 11/37] [CIFS] SMBD: Post a receive request Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:20 +0200
  [[PATCH v1] 15/37] [CIFS] SMBD: Post a SMBD data transfer message with data payload Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    Re: [[PATCH v1] 15/37] [CIFS] SMBD: Post a SMBD data transfer  message with data payload Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:30 +0200
    RE: [[PATCH v1] 15/37] [CIFS] SMBD: Post a SMBD data transfer message  with data payload Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 22:30 +0200
  [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport parameters and default values Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    Re: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD  transport parameters and default values Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:20 +0200
      RE: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport  parameters and default values Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 21:30 +0200
        RE: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport  parameters and default values Long Li <longli@microsoft.com> - 2017-08-15 01:00 +0200
  [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    Re: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Stefan Metzmacher <metze@samba.org> - 2017-08-08 09:10 +0200
      RE: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Long Li <longli@microsoft.com> - 2017-08-12 10:40 +0200
        Re: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Christoph Hellwig <hch@infradead.org> - 2017-08-12 21:00 +0200
        Re: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Stefan Metzmacher <metze@samba.org> - 2017-08-14 16:20 +0200
          RE: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Long Li <longli@microsoft.com> - 2017-08-14 20:20 +0200
    Re: [[PATCH v1] 02/37] [CIFS] SMBD: Add structure for SMBD transport Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:20 +0200
  [[PATCH v1] 18/37] [CIFS] SMBD: Implement API for upper layer to send data Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    RE: [[PATCH v1] 18/37] [CIFS] SMBD: Implement API for upper layer to  send data Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 22:50 +0200
      RE: [[PATCH v1] 18/37] [CIFS] SMBD: Implement API for upper layer to  send data Long Li <longli@microsoft.com> - 2017-08-20 01:50 +0200
  [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    Re: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:20 +0200
      RE: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ Long Li <longli@microsoft.com> - 2017-08-14 20:20 +0200
  [[PATCH v1] 09/37] [CIFS] SMBD: Add SMBD request and cache Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
  [[PATCH v1] 05/37] [CIFS] SMBD: Implement API for upper layer to create SMBD transport and establish RDMA connection Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
    RE: [[PATCH v1] 05/37] [CIFS] SMBD: Implement API for upper layer to  create SMBD transport and establish RDMA connection Tom Talpey <ttalpey@microsoft.com> - 2017-08-14 22:00 +0200
  [[PATCH v1] 17/37] [CIFS] SMBD: Track status for transport Long Li <longli@exchange.microsoft.com> - 2017-08-02 22:30 +0200
  Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:30 +0200
    Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:40 +0200
    RE: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Long Li <longli@microsoft.com> - 2017-08-14 19:10 +0200

csiph-web