RE: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ

From	Long Li <longli@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ
Date	2017-08-14 20:20 +0200
Message-ID	<ues81-7vo-7@gated-at.bofh.it> (permalink)
References	<ua8hz-6jk-3@gated-at.bofh.it> <ua8rg-6nd-17@gated-at.bofh.it> <udY9Y-5Xf-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Sunday, August 13, 2017 3:20 AM
> To: Long Li <longli@microsoft.com>
> Cc: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org; Long Li
> <longli@microsoft.com>
> Subject: Re: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from
> CQ
> 
> You seem to be doing memory allocations and frees for every packet on the
> write.  At least for other RDMA protocols that would have been a major
> performance issue.

The size of SGE array passed to IB is unknown, so I don't know how much to pre-allocate in advance. But it seems this size is not big when passed down from CIFS. I will look at pre-allocating buffer if this is an issue.

> 
> Do you have any performance numbers and/or profiles of the code?

I will look into profiling.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ Christoph Hellwig <hch@infradead.org> - 2017-08-13 12:20 +0200
  RE: [[PATCH v1] 12/37] [CIFS] SMBD: Handle send completion from CQ Long Li <longli@microsoft.com> - 2017-08-14 20:20 +0200

csiph-web