[PATCH 3/3] ALSA: rme96: Adjust five checks for null pointers

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] ALSA: rme96: Adjust five checks for null pointers
Date	Sat, 12 Aug 2017 15:50:01 +0200
Message-ID	<udEXD-1pb-9@gated-at.bofh.it> (permalink)
References	<udENY-1ls-15@gated-at.bofh.it>
X-Original-To	alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>, Julia Lawall <Julia.Lawall@lip6.fr>, Takashi Iwai <tiwai@suse.com>, Takashi Sakamoto <o-takashi@sakamocchi.jp>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-GB
Content-Transfer-Encoding	8bit
X-Provags-ID	V03:K0:BibFvcrPVksp27XEBPqpis/ovWBBk7+umnhCQZ+qt7wOwGj83yr zYARlLt/MPUYliSnf/wBbWBhgpctRWCgj3qDkFkZIWCcWioMubEB50MMUBrRwLtwbP3bLY6 W7zgiDkH9L97hlmPEHtBJLfjLT6bArQtPWDNZrXjcKYOqA/39orXH5fuJ8EBjhiQ3ccbWDI 3gAijqztFd3K5ddjhR5jA==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:Eta9vO0KO+k=:hhoxsn10ZCxiKDhsYw9QIQ JRx8N9Kr0/D6B9GUpzNtnBvE//g7lA0oGGHx1yFvdElZxufjBcFqMhFDJVmhkGq+naH5NdVnW IazcAOJYZ1DKEymR4yynd1CF87l2MUqzYB1aZwpLIJZmOkLJTOAysnoWWVJRhA3OHgGHSiP/p sOrJ8ZiiNv+16ikFC8RMZs6uS3zVzZvOHyQ/nzTyYPr5ZLc/aGqBjezIKhuDDqwHEOZQq4WMj zif9PsHi01jOiqrqHvnmqGow72+F3nedpyey95+AR8Pn+4/0PsTKjesBs1Sh0UkznaIXPsdp0 fmkdH7Fp3hblSnFe60RttczqSE2iij951aePfPcugcg5iN75AW/sPlgn3tZfdabJUqMKzuy7c xQ8HdL94Bz+2/zKk3atBXKmlbIjXhy/5n4HsckNznxB0izF86k9Y9S5t+Tx07LMZsS71MwLpT NZ8yZ3RIko/7hKC6iQwnj3fxTKM8/ZpoH+djy7AdeVoKi+gzvVVDhxwzfbFA1AAg3+1OZ94Ls UWzYDt4xAmYLzHXvrWwxAZJ7chtLn/4L4nziHYoEXgjC17Vgnpz86p5Y4MesO8h5CxQ+hMRRD l3tbFAxjFQlWX+KN7e/ATwPlMChSPEL4Xzp6iS2vDthPAVL1Vva5QslYVSM3VrHtXb9YXUoRE Jztugt/f5AFAShhWSL3gBCqX8lah/6l4+Dgvt1owtAkGLkcVPPeB5t7mf0hCHEJHKxd2qowy+ Es0f1QmgkmfDp1FT9egFOKg9fuXcisD79Izfm3I1hG+hUPwARmbi7CrSBdKx+BjrDugQdhO7P n830d3OLVeUabYtujpX1PuTZxTcPNt5+jXqyQCYTnWB7Va6kmo=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	71
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Sat, 12 Aug 2017 15:42:24 +0200
X-Original-Message-ID	<9ae3600a-0a71-a957-15b2-f31e0ffab912@users.sourceforge.net>
X-Original-References	<b38ee17e-f2ed-2bd7-6bc1-524ab4b3eb02@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1710281

Show key headers only | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 12 Aug 2017 15:18:56 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written …

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/pci/rme96.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/pci/rme96.c b/sound/pci/rme96.c
index 0cdfd53b7796..b488d74c3b99 100644
--- a/sound/pci/rme96.c
+++ b/sound/pci/rme96.c
@@ -1199,7 +1199,7 @@ snd_rme96_playback_spdif_open(struct snd_pcm_substream *substream)
 
 	snd_pcm_set_sync(substream);
 	spin_lock_irq(&rme96->lock);	
-        if (rme96->playback_substream != NULL) {
+	if (rme96->playback_substream) {
 		spin_unlock_irq(&rme96->lock);
                 return -EBUSY;
         }
@@ -1248,7 +1248,7 @@ snd_rme96_capture_spdif_open(struct snd_pcm_substream *substream)
         }
         
 	spin_lock_irq(&rme96->lock);
-        if (rme96->capture_substream != NULL) {
+	if (rme96->capture_substream) {
 		spin_unlock_irq(&rme96->lock);
                 return -EBUSY;
         }
@@ -1268,7 +1268,7 @@ snd_rme96_playback_adat_open(struct snd_pcm_substream *substream)
 	
 	snd_pcm_set_sync(substream);
 	spin_lock_irq(&rme96->lock);	
-        if (rme96->playback_substream != NULL) {
+	if (rme96->playback_substream) {
 		spin_unlock_irq(&rme96->lock);
                 return -EBUSY;
         }
@@ -1315,7 +1315,7 @@ snd_rme96_capture_adat_open(struct snd_pcm_substream *substream)
         }
         
 	spin_lock_irq(&rme96->lock);	
-        if (rme96->capture_substream != NULL) {
+	if (rme96->capture_substream) {
 		spin_unlock_irq(&rme96->lock);
                 return -EBUSY;
         }
@@ -1578,9 +1578,9 @@ snd_rme96_free(void *private_data)
 {
 	struct rme96 *rme96 = (struct rme96 *)private_data;
 
-	if (rme96 == NULL) {
+	if (!rme96)
 	        return;
-	}
+
 	if (rme96->irq >= 0) {
 		snd_rme96_trigger(rme96, RME96_STOP_BOTH);
 		rme96->areg &= ~RME96_AR_DAC_EN;
-- 
2.14.0

Thread

[PATCH 0/3] ALSA: rme96: Adjustments for six function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:40 +0200
  [PATCH 1/3] ALSA: rme96: Delete two error messages for a failed  memory allocation in snd_rme96_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:50 +0200
  [PATCH 2/3] ALSA: rme96: Use common error handling code in  snd_rme96_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:50 +0200
  [PATCH 3/3] ALSA: rme96: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:50 +0200
  Re: [PATCH 0/3] ALSA: rme96: Adjustments for six function implementations Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:30 +0200

csiph-web