Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1707323

[PATCH 0/4] net-next: dsa: fix flow dissection

Show all headers | View raw

RPS and probably other kernel features are currently broken on some if not
all DSA devices. The root cause of this is that skb_hash will call the
flow_dissector. At this point the skb still contains the magic switch
header and the skb->protocol field is not set up to the correct 802.3
value yet. By the time the tag specific code is called, removing the header
and properly setting the protocol an invalid hash is already set. In the
case of the mt7530 this will result in all flows always having the same
hash.

Changes since RFC:
* use a callback instead of static values
* add cover letter

John Crispin (4):
  net-next: dsa: move struct dsa_device_ops to the global header file
  net-next: dsa: add flow_dissect callback to struct dsa_device_ops
  net-next: tag_mtk: add flow_dissect callback to the ops struct
  net-next: dsa: fix flow dissection

 include/net/dsa.h         |  9 +++++++++
 net/core/flow_dissector.c | 12 ++++++++++++
 net/dsa/dsa_priv.h        |  7 -------
 net/dsa/tag_mtk.c         | 14 ++++++++++++--
 4 files changed, 33 insertions(+), 9 deletions(-)

-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-08-09 14:50 +0200
  [PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the ops struct John Crispin <john@phrozen.org> - 2017-08-09 14:50 +0200
    Re: [PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the  ops struct Andrew Lunn <andrew@lunn.ch> - 2017-08-09 16:00 +0200
  Re: [PATCH 0/4] net-next: dsa: fix flow dissection Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-09 17:20 +0200
  Re: [PATCH 0/4] net-next: dsa: fix flow dissection David Miller <davem@davemloft.net> - 2017-08-10 08:00 +0200
    Re: [PATCH 0/4] net-next: dsa: fix flow dissection Eric Dumazet <eric.dumazet@gmail.com> - 2017-08-10 08:50 +0200
      Re: [PATCH 0/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-08-10 09:50 +0200
      Re: [PATCH 0/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-08-10 10:20 +0200

csiph-web