Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1708303

Re: [PATCH 0/4] net-next: dsa: fix flow dissection

Show all headers | View raw

On 10/08/17 08:42, Eric Dumazet wrote:
> On Wed, 2017-08-09 at 22:52 -0700, David Miller wrote:
>> From: John Crispin <john@phrozen.org>
>> Date: Wed,  9 Aug 2017 14:41:15 +0200
>>
>>> RPS and probably other kernel features are currently broken on some if not
>>> all DSA devices. The root cause of this is that skb_hash will call the
>>> flow_dissector. At this point the skb still contains the magic switch
>>> header and the skb->protocol field is not set up to the correct 802.3
>>> value yet. By the time the tag specific code is called, removing the header
>>> and properly setting the protocol an invalid hash is already set. In the
>>> case of the mt7530 this will result in all flows always having the same
>>> hash.
>>>
>>> Changes since RFC:
>>> * use a callback instead of static values
>>> * add cover letter
>> Series applied, thanks.
> Is this related ?
>
> net/core/flow_dissector.c: In function '__skb_flow_dissect':
> net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr'
>      ops = skb->dev->dsa_ptr->tag_ops;
>                    ^
> make[3]: *** [net/core/flow_dissector.o] Error 1
>
>
Hi Eric,

I have just sent the fix for this compile error

     John

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-08-09 14:50 +0200
  [PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the ops struct John Crispin <john@phrozen.org> - 2017-08-09 14:50 +0200
    Re: [PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the  ops struct Andrew Lunn <andrew@lunn.ch> - 2017-08-09 16:00 +0200
  Re: [PATCH 0/4] net-next: dsa: fix flow dissection Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-09 17:20 +0200
  Re: [PATCH 0/4] net-next: dsa: fix flow dissection David Miller <davem@davemloft.net> - 2017-08-10 08:00 +0200
    Re: [PATCH 0/4] net-next: dsa: fix flow dissection Eric Dumazet <eric.dumazet@gmail.com> - 2017-08-10 08:50 +0200
      Re: [PATCH 0/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-08-10 09:50 +0200
      Re: [PATCH 0/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-08-10 10:20 +0200

csiph-web