Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706904

Re: [PATCH] loop: fix to a race condition due to the early registration of device

From Omar Sandoval <osandov@osandov.com>
Newsgroups linux.kernel
Subject Re: [PATCH] loop: fix to a race condition due to the early registration of device
Date 2017-08-09 00:10 +0200
Message-ID <uckRj-6mw-3@gated-at.bofh.it> (permalink)
References <ubG7w-2hk-13@gated-at.bofh.it> <ubPub-8bG-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
> The early device registration made possible a race leading to allocations
> of disks with wrong minors.
> 
> This patch moves the device registration further down the loop_init
> function to make the race infeasible.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Volkov <avolkov@ispras.ru>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>

Hi, Anton,

Were you able to reproduce this issue or was it purely theoretical? If
the former, it'd be nice if you could add a test case to blktests [1].

1: https://github.com/osandov/blktests

Thanks!
Omar

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Possible race in loop.ko Ming Lei <tom.leiming@gmail.com> - 2017-08-01 14:40 +0200
  [PATCH] loop: fix to a race condition due to the early registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-03 17:10 +0200
    Re: [PATCH] loop: fix to a race condition due to the early  registration of device Ming Lei <tom.leiming@gmail.com> - 2017-08-07 04:40 +0200
      [PATCH] loop: fix to a race condition due to the early registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-07 14:40 +0200
        Re: [PATCH] loop: fix to a race condition due to the early  registration of device Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-07 15:00 +0200
          Re: [PATCH] loop: fix to a race condition due to the early  registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-07 15:10 +0200
            Re: [PATCH] loop: fix to a race condition due to the early  registration of device Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-07 15:30 +0200
        Re: [PATCH] loop: fix to a race condition due to the early  registration of device Omar Sandoval <osandov@osandov.com> - 2017-08-09 00:10 +0200
          Re: [PATCH] loop: fix to a race condition due to the early  registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-10 17:50 +0200

csiph-web