Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703184

[PATCH] loop: fix to a race condition due to the early registration of device

Show all headers | View raw

The early device registration made possible a race leading to allocations
of disks with wrong minors.

This patch moves the device registration further down the loop_init
function to make the race infeasible.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Volkov <avolkov@ispras.ru>
---
 drivers/block/loop.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index ef83349..2fbd4089 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1996,10 +1996,6 @@ static int __init loop_init(void)
 	struct loop_device *lo;
 	int err;
 
-	err = misc_register(&loop_misc);
-	if (err < 0)
-		return err;
-
 	part_shift = 0;
 	if (max_part > 0) {
 		part_shift = fls(max_part);
@@ -2017,12 +2013,12 @@ static int __init loop_init(void)
 
 	if ((1UL << part_shift) > DISK_MAX_PARTS) {
 		err = -EINVAL;
-		goto misc_out;
+		goto err_out;
 	}
 
 	if (max_loop > 1UL << (MINORBITS - part_shift)) {
 		err = -EINVAL;
-		goto misc_out;
+		goto err_out;
 	}
 
 	/*
@@ -2041,6 +2037,11 @@ static int __init loop_init(void)
 		range = 1UL << MINORBITS;
 	}
 
+	err = misc_register(&loop_misc);
+	if (err < 0)
+		goto err_out;
+
+
 	if (register_blkdev(LOOP_MAJOR, "loop")) {
 		err = -EIO;
 		goto misc_out;
@@ -2060,6 +2061,7 @@ static int __init loop_init(void)
 
 misc_out:
 	misc_deregister(&loop_misc);
+err_out:
 	return err;
 }
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Possible race in loop.ko Ming Lei <tom.leiming@gmail.com> - 2017-08-01 14:40 +0200
  [PATCH] loop: fix to a race condition due to the early registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-03 17:10 +0200
    Re: [PATCH] loop: fix to a race condition due to the early  registration of device Ming Lei <tom.leiming@gmail.com> - 2017-08-07 04:40 +0200
      [PATCH] loop: fix to a race condition due to the early registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-07 14:40 +0200
        Re: [PATCH] loop: fix to a race condition due to the early  registration of device Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-07 15:00 +0200
          Re: [PATCH] loop: fix to a race condition due to the early  registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-07 15:10 +0200
            Re: [PATCH] loop: fix to a race condition due to the early  registration of device Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-07 15:30 +0200
        Re: [PATCH] loop: fix to a race condition due to the early  registration of device Omar Sandoval <osandov@osandov.com> - 2017-08-09 00:10 +0200
          Re: [PATCH] loop: fix to a race condition due to the early  registration of device Anton Volkov <avolkov@ispras.ru> - 2017-08-10 17:50 +0200

csiph-web