Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1706586

Re: [PATCH 1/2] arm64: introduce separated bits for mm_context_t flags

From Catalin Marinas <catalin.marinas@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] arm64: introduce separated bits for mm_context_t flags
Date 2017-08-08 16:00 +0200
Message-ID <ucdd8-Hf-13@gated-at.bofh.it> (permalink)
References <ucdd8-Hf-9@gated-at.bofh.it> <ucdd8-Hf-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Aug 05, 2017 at 05:40:21PM +0300, Yury Norov wrote:
> diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h
> index 5468c834b072..2c57b06b2883 100644
> --- a/arch/arm64/include/asm/mmu.h
> +++ b/arch/arm64/include/asm/mmu.h
> @@ -16,6 +16,8 @@
>  #ifndef __ASM_MMU_H
>  #define __ASM_MMU_H
>  
> +#define MMCF_AARCH32	0x0	/* MM hosts AArch32 executables */

Nitpick: drop 0x since it's a bit number not a flag value. We could,
however, make it a value and just stop using (set|clear)_bit functions.
There is no atomicity issue here.

-- 
Catalin

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] arm64: introduce separated bits for mm_context_t  flags Catalin Marinas <catalin.marinas@arm.com> - 2017-08-08 16:00 +0200

csiph-web