scsi: qla2xxx: use dma_mapping_error to check map errors

From	Pan Bian <bianpan2016@163.com>
Newsgroups	linux.kernel
Subject	scsi: qla2xxx: use dma_mapping_error to check map errors
Date	2017-08-08 16:00 +0200
Message-ID	<ucdd7-Hf-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The return value of dma_map_single() should be checked by
dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its
return value is checked against NULL, which could result in failures.

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 7c6d1a4..eafb709 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -5817,7 +5817,7 @@ struct cs84xx_mgmt_cmd {
 
 	dd_dma = dma_map_single(&vha->hw->pdev->dev,
 	    dd_buf, size, DMA_FROM_DEVICE);
-	if (!dd_dma) {
+	if (dma_mapping_error(&vha->hw->pdev->dev, dd_dma)) {
 		ql_log(ql_log_warn, vha, 0x1194, "Failed to map dma buffer.\n");
 		return QLA_MEMORY_ALLOC_FAILED;
 	}
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

scsi: qla2xxx: use dma_mapping_error to check map errors Pan Bian <bianpan2016@163.com> - 2017-08-08 16:00 +0200
  Re: scsi: qla2xxx: use dma_mapping_error to check map errors "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-08-08 17:30 +0200
  Re: scsi: qla2xxx: use dma_mapping_error to check map errors "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-11 02:10 +0200

csiph-web