Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1707613

Re: [v6] wlcore: add missing nvs file name info for wilink8

Show all headers | View raw

* Tony Lindgren <tony@atomide.com> [170809 10:26]:
> * Reizer, Eyal <eyalr@ti.com> [170809 00:55]:
> > --- a/drivers/net/wireless/ti/wlcore/main.c
> > +++ b/drivers/net/wireless/ti/wlcore/main.c
> > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl)
> >  		nic_addr = wl->fuse_nic_addr + 1;
> >  	}
> >  
> > +	if (oui_addr == 0xdeadbe && nic_addr == 0xef0000) {
> > +		wl1271_warning("Detected unconfigured mac address in nvs.\n"
> > +				"derive from fuse instead.\n"
> > +				"in case of using a wl12xx device, your "
> > +				"device performance may not be optimized.\n"
> > +				"Please use the calibrator tool to configure "
> > +				"your device.\n"
> > +				"When using a wl18xx device this default nvs "
> > +				"file can be removed from the file system\n");
> > +
> > +		oui_addr = wl->fuse_oui_addr;
> > +		/* fuse has the BD_ADDR, the WLAN addresses are the next two */
> > +		nic_addr = wl->fuse_nic_addr + 1;
> > +	}
> > +
> >  	wl12xx_derive_mac_addresses(wl, oui_addr, nic_addr);
> 
> I just gave this a quick try on omap3-evm with wl1271, now I get
> mac address of 00:00:00:00:00:01 :) So looks like at least wl1271 needs
> to use the random mac address here.
> 
> Note that we should now have struct wilink_family_data available
> so maybe that can be used to check if the hardware mac address
> exists?

Or actually, in the case where no hardawre mac address exists,
the mac is all zeroes at this point it seems. So maybe that
can be used to determine if a random mac address should be used
here.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[v6] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-09 10:00 +0200
  Re: [v6] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-09 19:30 +0200
  Re: [v6] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-09 19:30 +0200
    Re: [v6] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-09 23:20 +0200
      RE: [v6] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-10 08:40 +0200
        Re: [v6] wlcore: add missing nvs file name info for wilink8 Kalle Valo <kvalo@codeaurora.org> - 2017-08-10 09:50 +0200
          RE: [v6] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-10 10:00 +0200
        Re: [v6] wlcore: add missing nvs file name info for wilink8 Julian Calaby <julian.calaby@gmail.com> - 2017-08-10 10:00 +0200
          RE: [v6] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-10 10:00 +0200
      RE: [v6] wlcore: add missing nvs file name info for wilink8 "Reizer, Eyal" <eyalr@ti.com> - 2017-08-10 16:30 +0200
        Re: [v6] wlcore: add missing nvs file name info for wilink8 Tony Lindgren <tony@atomide.com> - 2017-08-10 19:30 +0200

csiph-web