Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1707422
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 9/9] ACPI-video: Improve a size determination in four functions |
| Date | 2017-08-09 17:50 +0200 |
| Message-ID | <ucBp7-PO-1@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <seffb-4Kg-7@gated-at.bofh.it> <semJH-1kY-9@gated-at.bofh.it> <sepod-36Y-1@gated-at.bofh.it> <sevN0-7ef-19@gated-at.bofh.it> <ucBfr-Mz-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 9 Aug 2017 16:45:29 +0200
Replace the specification of a data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/acpi/acpi_video.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 3cc1798676ab..d999f4e49b98 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -1140,7 +1140,7 @@ acpi_video_bus_get_one_device(struct acpi_device *device,
if (ACPI_FAILURE(status))
return 0;
- data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
+ data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data)
return -ENOMEM;
@@ -1321,7 +1321,7 @@ static int acpi_video_device_enumerate(struct acpi_video_bus *video)
dod->package.count));
active_list = kcalloc(1 + dod->package.count,
- sizeof(struct acpi_video_enumerated_device),
+ sizeof(*active_list),
GFP_KERNEL);
if (!active_list) {
status = -ENOMEM;
@@ -1742,7 +1742,7 @@ static void acpi_video_dev_register_backlight(struct acpi_video_device *device)
pci_dev_put(pdev);
}
- memset(&props, 0, sizeof(struct backlight_properties));
+ memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_FIRMWARE;
props.max_brightness =
device->brightness->count - ACPI_VIDEO_FIRST_LEVEL - 1;
@@ -2007,7 +2007,7 @@ static int acpi_video_bus_add(struct acpi_device *device)
return -ENODEV;
}
- video = kzalloc(sizeof(struct acpi_video_bus), GFP_KERNEL);
+ video = kzalloc(sizeof(*video), GFP_KERNEL);
if (!video)
return -ENOMEM;
--
2.13.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/9] ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:40 +0200 [PATCH v2 1/9] ACPI-video: Use kmalloc_array() in acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:40 +0200 [PATCH v2 3/9] ACPI-video: Delete an error message for a failed kzalloc() call SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:40 +0200 [PATCH v2 2/9] ACPI-video: Return directly after a failed device query SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:40 +0200 [PATCH v2 9/9] ACPI-video: Improve a size determination in four functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:50 +0200 [PATCH v2 8/9] ACPI-video: Move four assignments in acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:50 +0200 [PATCH v2 4/9] ACPI-video: Return directly after a failed input_allocate_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:50 +0200 [PATCH v2 6/9] ACPI-video: Improve a jump target in acpi_video_switch_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:50 +0200 [PATCH v2 7/9] ACPI-video: Delete an unnecessary initialisation in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:50 +0200 [PATCH v2 5/9] ACPI-video: Delete unnecessary if statement in acpi_video_switch_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-09 17:50 +0200
csiph-web