Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API

From	Andy Lutomirski <luto@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API
Date	2017-08-06 17:50 +0200
Message-ID	<ubvYu-466-19@gated-at.bofh.it> (permalink)
References	<ua1SN-1Yb-3@gated-at.bofh.it> <uaMoG-br-23@gated-at.bofh.it> <uaMI1-iG-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 4, 2017 at 8:27 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Aug 4, 2017 at 6:01 PM, Andy Lutomirski <luto@kernel.org> wrote:
>>> On Aug 2, 2017, at 9:28 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>>
>>> There are new types and helpers that are supposed to be used in new code.
>>>
>>> As a preparation to get rid of legacy types and API functions do
>>> the conversion here.
>>>
>>> While here, update Copyright to reflect this change along with previous
>>> one for the topic.
>
>>> struct guid_block {
>>> -    char guid[16];
>>> +    guid_t guid;
>>
>> NAK.  guid_block is a firmware interface, so opaque kernel types don't
>> belong in it.
>
> I f we leave this, what do you think about everything else?

Assuming it works, it's fine with me.  I'd be happy to test.

Keep in mind that this beast is a *little-endian* GUID abomination,
and I don't see generic conversion helpers.  Something might need to
be added.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-02 15:30 +0200
  Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Lutomirski <luto@kernel.org> - 2017-08-04 17:10 +0200
    Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-04 17:30 +0200
      Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Lutomirski <luto@kernel.org> - 2017-08-06 17:50 +0200

csiph-web