Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704073

Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API

Show all headers | View raw

On Fri, Aug 4, 2017 at 6:01 PM, Andy Lutomirski <luto@kernel.org> wrote:
>> On Aug 2, 2017, at 9:28 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>
>> There are new types and helpers that are supposed to be used in new code.
>>
>> As a preparation to get rid of legacy types and API functions do
>> the conversion here.
>>
>> While here, update Copyright to reflect this change along with previous
>> one for the topic.

>> struct guid_block {
>> -    char guid[16];
>> +    guid_t guid;
>
> NAK.  guid_block is a firmware interface, so opaque kernel types don't
> belong in it.

I f we leave this, what do you think about everything else?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-02 15:30 +0200
  Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Lutomirski <luto@kernel.org> - 2017-08-04 17:10 +0200
    Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-04 17:30 +0200
      Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API Andy Lutomirski <luto@kernel.org> - 2017-08-06 17:50 +0200

csiph-web