Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1704768

[PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.

Path csiph.com!goblin1!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.
Date Sun, 06 Aug 2017 09:20:02 +0200
Message-ID <ubo0W-7Da-5@gated-at.bofh.it> (permalink)
References <ubnRg-7zP-13@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jHJHjC5BbX+klJ5b022dr0pnlbef3kPGQQXcdDuJeIU=; b=sS1ZH4n8IE/r7lF2Y10Kg5MAp8/q1s2OYab3P/66GhFfOAzN92WOUcnp1myLukL7Uz FhU6Uy/6Bl37uQV45A/gSSIP2j8FUavtJKyd3+zlQHLwTeck3jZswDKqOcwcS/q6GWOj P2L+mjV1Ip2GFDNUVH7w5O5FacaJCuBHa82ISB+MlvuP6bkRU7rnqHXMdr7wz54j7lVp 3xHVDJw4AUN5HT9M04WYTchsPetgMCi0h4CUYx619sy0A2QpQEKRQUxkp44M2HpE/1Cj 3ESZoSrfXF0rzTJU+sA7NyzByDN1sEXuXdrGlBqsI9MDcy1NIEKPubFsbkbOXSzhSB5Q 4NWg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jHJHjC5BbX+klJ5b022dr0pnlbef3kPGQQXcdDuJeIU=; b=Ui/z6EBsDoqQ40vR/OX6m3DpgXm5b8BwStQ1sIjL2lqyUiF+Jx+PZBWKvgz5Pt7Itv N8JUszXIWBRRe6YJKnYBhXgrIGnflSeiCytP9bsBDW6+Cp5Em0EjIaleZJy1t4uiPxc1 Hv5Yko/lL1D7XbJGpS3UhZM1e58DUrcOCzR+tsGQ6ITVmugWRG0rFPmbIjY5u407c6Vb Wbq+eZE9GA8EyBecWWP+00YvdqTQMZiNCllJ6Wmr2YS+EGWh2Z6bQLHgC2AfjOdTppYZ FulaCi+m2Sj8rGDtOrdyWT0soAamzDzB371Ud/4+8/nAoUl63J/ThZNXmOXDOFXh/4ak Fwrg==
X-Gm-Message-State AIVw111pHTSMGH6prrv+3Av8FgBHiiAvj3xWmJRqT+jbG0mB6w1i9FE8 3xg5sBK2G56ihQ==
X-Received by 10.98.101.4 with SMTP id z4mr7803259pfb.163.1502003383074; Sun, 06 Aug 2017 00:09:43 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 6 Aug 2017 12:39:28 +0530
X-Original-Message-ID <1502003368-12355-3-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-References <1502003368-12355-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1704768

Show key headers only | View raw


usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/video/fbdev/udlfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 05ef657..d836e6e 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -54,7 +54,7 @@ static const u32 udlfb_info_flags = FBINFO_DEFAULT | FBINFO_READS_FAST |
  * which is compatible with all known USB 2.0 era graphics chips and firmware,
  * but allows DisplayLink to increment those for any future incompatible chips
  */
-static struct usb_device_id id_table[] = {
+static const struct usb_device_id id_table[] = {
 	{.idVendor = 0x17e9,
 	 .bInterfaceClass = 0xff,
 	 .bInterfaceSubClass = 0x00,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:10 +0200
  [PATCH 1/2] video: fbdev: smscufx: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:20 +0200
  [PATCH 2/2] video: fbdev: udlfb: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:20 +0200

csiph-web